fix(core): Use Redis prefix everywhere (no-changelog) #23366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 9m 17s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure we apply the
N8N_REDIS_KEY_PREFIXwhenever we publish or subscribe to Redis PubSub.If two deployments of n8n share a single Redis, we try to support isolating them by supplying a
N8N_REDIS_KEY_PREFIXenvironment variable.However, we don't apply this prefix for certain messages -- worker status, webhook activation. This means these messages can end up at the wrong instance, causing errors and confusion. For example, the
/settings/workersendpoint returns all of the workers of all instances using the Redis server.This change ensures that the prefix is applied for all of these usages.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1761
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)