-
Notifications
You must be signed in to change notification settings - Fork 339
fix(iroh): Properly set quinn paths to available when holepunched #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3864/docs/iroh/ Last updated: 2026-01-16T15:34:56Z |
dignifiedquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
|
I'm still trying to figure out how to write a good test for this. I should be pretty close though. |
|
Okay this took me way too long. But I can only write a test that really works, if the quinn the test uses current quinn main. |
Description
Fixes #3862
The problem was the following on the client side:
RemoteStateActor::open_pathThe fix is to actually set the path to available in all cases.
Also in this PR:
?path_idto%path_idto use the display impl.iroh::_event::path::set_status, which I personally found really useful when debugging.main, because otherwise we don't have the required quinn fixes to make hole-punching work correctly, but we need it to work for the regression test I added.Notes & open questions
Change checklist