Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@utoni
Copy link
Collaborator

@utoni utoni commented Jun 16, 2022

Signed-off-by: lns [email protected]

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging 4def22b into 20a29c3 - view on LGTM.com

new alerts:

  • 1 for Bad check for overflow of integer addition

@utoni utoni force-pushed the add/collectd-protocol branch from 4def22b to 66d4afb Compare June 16, 2022 14:19
@IvanNardi
Copy link
Collaborator

@utoni , all the attached flows are classified as collectd; is that correct or are they false positives?
collectd.zip

@utoni
Copy link
Collaborator Author

utoni commented Jun 17, 2022

false positives, need to increase COLLECTD_MIN_BLOCKS_REQUIRED or instead of setting a malformed packet risk, just exclude it immediately =)

@utoni utoni force-pushed the add/collectd-protocol branch from 66d4afb to 1987dbc Compare June 17, 2022 14:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IvanNardi
Copy link
Collaborator

false positives, need to increase COLLECTD_MIN_BLOCKS_REQUIRED or instead of setting a malformed packet risk, just exclude it immediately =)

Thanks for the improvements!

@IvanNardi IvanNardi merged commit 432de5e into ntop:dev Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants