RTP: rework code #2021
Merged
RTP: rework code #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab7b655 to
0fbd2a5
Compare
utoni
reviewed
Jun 22, 2023
utoni
reviewed
Jun 22, 2023
Try avoiding false positives: look for 3 RTP packets before classifing the flow as such. Add a generic function `is_rtp_or_rtcp()` to identify RTP/RTCP packets also in other dissectors (see 3608ab0 commit message for an example)
0fbd2a5 to
2095a82
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
utoni
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try avoiding false positives: look for 3 RTP packets before classifing the flow as such.
Add a generic function
is_rtp_or_rtcp()to identify RTP/RTCP packets also in other dissectors (see 3608ab0 commit message for an example)