Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@utoni
Copy link
Collaborator

@utoni utoni commented Nov 14, 2023

Provide a more structured dissection of zero-terminated strings, TFTP mode as well as TFTP options.
With this PR dissection of OACK packets is possible. See #2075.

@utoni utoni force-pushed the improved/tftp-dissect branch 2 times, most recently from 4e756a0 to daed65c Compare November 14, 2023 19:40
@utoni
Copy link
Collaborator Author

utoni commented Nov 14, 2023

ping @thomasjwinter

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanNardi
Copy link
Collaborator

One week later... I think we can safely merge that. @utoni, do you agree? Could you rebase, please?

Signed-off-by: Toni Uhlig <[email protected]>
@utoni utoni force-pushed the improved/tftp-dissect branch from daed65c to 44e824f Compare November 21, 2023 13:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@IvanNardi IvanNardi merged commit 21f2574 into ntop:dev Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants