Add support for ActiveRecord 6.0 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b30fe8 to
28dbbd4
Compare
e42098a to
7889da6
Compare
I am getting this error on your branch tho. I am not sure, if i set it up incorrectly, or if this is a problem with the branch. |
|
does it happen also for the master branch of the gem on github? or only on my branch? |
|
yes, same error. |
different trace tho. |
|
The build seems to be green meanwhile. |
|
Is someone able to be a maintainer of this project. You don't need to do too much, just oversee PR's like this and review/merge as needed (you can then review/merge this diff). Ping me if you're interested and I can add you to the project. Unfortunately I don't use this project anymore so I have stepped back to facilitate others who are able to maintain it. |
|
I guess i'm not the right person but what about creating a pinned "call for maintainers" issue? |
|
I think we can find a maintainer. Feel free to post an issue and mention people who might be interested, people here are all forking this project (and then others are using this code) so there's already lots of effort to use this code. I think the main issue is people think they are signing up for work (they aren't). They are probably going to just review one Pull Request every month and it'll be a easy merge or request changes. Or people are worried they are now responsible (they aren't, those who update the gem need to test, and it's only a test gem anyway). |
|
if you have the permissions, add me and I'll merge and release 😄 |
cabello
approved these changes
Jul 22, 2019
We use it in production ;) |
|
I am just waiting on @mnoack to sort it out how we gonna publish the next release to Rubygems. :) |
|
@cabello What's your rubygems email so I can give you permission, also I'll get it done quicker if you can tell me the command to run, from memory it's something like "gem owner nulldb --add youremail" |
|
Done. |
@scones did you manage a workaround? |
Merged
|
@thelastinuit no, i uncommented the gem and mocked all Models. so i actually had to set up a test db on my production mysql server to ensure flawless CI/CD. not the best solution, but it works. but it seems like you found a solution yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Rails 6.0 and adds ruby 2.5 and 2.6 to the build matrix on Travis.