fix: handle nitro-cloudflare-dev Promise bindings #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
4d07903 to
757e725
Compare
Contributor
|
Thanks for the help on this @onmax Did you see that with latest Nitro compat, we don't need to install |
Contributor
Author
|
I will be offline for the next week. Please feel free to iterate or close this PR if a better solution emerges. Merry Christmas to the whole team! And well done on this new NuxtHub; I'm really excited about everything that's happening in the Nuxt ecosystem! 2026 will be 🔥 |
Contributor
|
I will let @RihanArfan have a deep review at it once he's back from holidays :) |
- Add `hub.remote` option to use production Cloudflare bindings during dev - Fix Promise bindings from nitro-cloudflare-dev via getPlatformProxy - Change db import to dynamic to handle async bindings - Add isRemoteDev helper to reduce duplication - Fail loudly when remote bindings fail (no silent stub fallback) - Fix proxy.dispose() to actually call the function Fixes nuxt-hub#741 Fixes nuxt-hub#743
07128ba to
5617264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741
Fixes #743
Problem
nitro-cloudflare-devsetsglobalThis.__env__as a Promise initially. NuxtHub accessesglobalThis.__env__?.DBsynchronously which fails.Solution
Adds
hub.remote: trueoption to use production Cloudflare bindings (D1, KV, R2) during local development using wrangler'sgetPlatformProxy().Reproduction
The
-fixedfolder includes a pnpm patch with the fix.Configuration