Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: deduplicate defaults #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 2 commits into from
Apr 24, 2025
Merged

fix: deduplicate defaults #604

danielroe merged 2 commits into from
Apr 24, 2025

Conversation

@Akryum
Copy link
Contributor

@Akryum Akryum commented Apr 24, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With layers, default options might get duplicated which breaks the font detection.

@Akryum Akryum requested a review from danielroe as a code owner April 24, 2025 09:33
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 24, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/fonts@604

commit: 39ae097

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (7590802) to head (39ae097).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files          13       13           
  Lines        1073     1073           
  Branches      271      271           
=======================================
  Hits          899      899           
  Misses        169      169           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe merged commit 9732831 into nuxt:main Apr 24, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 24, 2025
Merged
@Akryum Akryum deleted the fix-duplicated-defaults-from-layers branch April 24, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Akryum @codecov-commenter @danielroe