Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

danielroe
Copy link
Member

resolves #508

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I wasn't able to reproduce the issue of preloading lower quality font files but this is a 'safe' attempt at fixing the issue in the interim.

(most of the diff of the PR is migrating to use FontFaceData from unifont, which has a new meta property

does it look okay to you @qwerzl? can you reproduce the issue?

@danielroe danielroe requested a review from qwerzl May 9, 2025 11:23
@cloudflare-workers-and-pages
Copy link

Deploying fonts with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: d4a1538
Status:Β βœ…Β  Deploy successful!
Preview URL: https://202c1af4.fonts-dsw.pages.dev
Branch Preview URL: https://fix-priority.fonts-dsw.pages.dev

View logs

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/fonts@617

commit: d4a1538

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 83.79%. Comparing base (db5fbf1) to head (d4a1538).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   83.78%   83.79%   +0.01%     
==========================================
  Files          13       13              
  Lines        1079     1080       +1     
  Branches      305      305              
==========================================
+ Hits          904      905       +1     
  Misses        166      166              
  Partials        9        9              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerzl
Copy link
Member

qwerzl commented May 9, 2025

I wasn't able to reproduce the issue of preloading lower quality font files but this is a 'safe' attempt at fixing the issue in the interim.

Yes, after the meta property was implemented in unifont I relooked at the issue and couldn't reproduce it either. I think there was a mistake when I first looked at it, my bad πŸ˜”

But I do think that using this property is a safer approach and we could utilize it for further optimizations (I'm still waiting for partial instancing support in klippa so we could move on with implementing those optimizations)

@danielroe danielroe merged commit a9e7c4f into main May 9, 2025
6 checks passed
@danielroe danielroe deleted the fix/priority branch May 9, 2025 11:54
@github-actions github-actions bot mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should not preload fallback fonts

3 participants