Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support setting remote images at build-time with NUXT_IMAGE_DOMAINS #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 22, 2024
Merged

feat: support setting remote images at build-time with NUXT_IMAGE_DOMAINS #1332

merged 11 commits into from
Apr 22, 2024

Conversation

@scottyzen
Copy link
Contributor

@scottyzen scottyzen commented Apr 21, 2024 •
edited
Loading

  • Add NUXT_IMAGE_DOMAINS environment variable to allow users to set the domains from an environment variable.
  • Update documentation on providers.md and provide an example.
  • Spelling of proccessed to processed

@scottyzen
Update 3.providers.md
dc7366c 
Update providers.md with instructions for setting the domain using environment variable
@scottyzen
add domainsFromENV logic
f10cfd2
@scottyzen scottyzen changed the title Add setting the domains using the NUXT_IMAGE_DOMAINS environment variable Add NUXT_IMAGE_DOMAINS environment variable Apr 22, 2024
@scottyzen scottyzen marked this pull request as ready for review April 22, 2024 00:12
danielroe
danielroe reviewed Apr 22, 2024
View reviewed changes
danielroe
danielroe reviewed Apr 22, 2024
View reviewed changes
@danielroe
Copy link
Member

Would you explain a bit more about why this would be needed?

@scottyzen
Copy link
Contributor Author

scottyzen commented Apr 22, 2024 •
edited
Loading

Hi @danielroe,

Sure, It's more of a "nice to have" than needed. It plays well with the NUXT_IMAGE_PROVIDER env variable that's already there. Most of the time those images are coming from a remote source so the domains need to be listed in the image options. This extra env variable just means to don't need to have any setting in your nuxt-config file for remote images to work.

danielroe
danielroe reviewed Apr 22, 2024
View reviewed changes
@danielroe danielroe changed the title Add NUXT_IMAGE_DOMAINS environment variable feat: support setting remote images at build-time with NUXT_IMAGE_DOMAINS Apr 22, 2024
@danielroe danielroe merged commit 1a227d2 into nuxt:main Apr 22, 2024
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
@numselli numselli mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scottyzen @danielroe