docs: make clearer that xxl is not a tailwind size
#1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tailwind has xl and 2xl
|
Hey there, In the future, I think it would be better to create an issue first and then create a PR with a change 🙏 I am not sure if we should do that as this change is dictated by Tailwind while NuxtImg can work on their own without it. Could you elaborate why this should be added/removed from NuxtImg? |
|
Hi @Baroshem I added the issue |
xxl is not a tailwind size
danielroe
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
=======================================
Coverage 62.87% 62.87%
=======================================
Files 79 79
Lines 3539 3539
Branches 412 412
=======================================
Hits 2225 2225
Misses 1285 1285
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #1633
❓ Type of change
📚 Description
Tailwind has xl and 2xl
https://tailwindcss.com/docs/responsive-design