feat: add new modifiers for imageengine with tests #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
==========================================
+ Coverage 64.25% 64.28% +0.02%
==========================================
Files 79 79
Lines 3696 3699 +3
Branches 426 426
==========================================
+ Hits 2375 2378 +3
Misses 1296 1296
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A - Small enhancement adding official ImageEngine directives
❓ Type of change
📚 Description
Added support for additional ImageEngine directives(modifiers) to enhance image optimization capabilities:
maxDprdirective: Controls maximum device pixel ratio for responsive imagesdownloaddirective: Enables download behavior for imagesproductletterboxfit option: Optimizes product image display with background and tolerance settingsAll changes are documented in the ImageEngine provider tests with comprehensive test cases covering each new directive.
References: