fix!: use URLSearchParams as default formatter
#1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 63.12% 63.03% -0.10%
==========================================
Files 77 77
Lines 3824 3793 -31
Branches 442 432 -10
==========================================
- Hits 2414 2391 -23
+ Misses 1384 1376 -8
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying nuxt-image with
|
| Latest commit: |
c46221f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5025adc.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-encoded-sirv.nuxt-image.pages.dev |
encodePath in provider formattersURLSearchParams as default formatter
URLSearchParams as default formatterURLSearchParams as default formatter
URLSearchParams as default formatterURLSearchParams as default formatter
Draft
DamianGlowala
pushed a commit
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
spotted an issue when testing
nuxi generate playground- one of the URLs was invalid (caused by passing30%as a value). You can test withdecodeURIComponent("https://demo.sirv.com/t-shirt-man.jpg?watermark=/watermark-v1.png&watermark.position=center&watermark.scale.width=30%&h=500")`This PR switches across to using URLSearchParams to handle encodings across all providers. If a user wants to provide a custom
joinWiththey now must provide a custom formatter (to avoid unnecessary bundling)I think it should be safe - but @pi0 may have other thoughts.