fix(hygraph): prevent broken image urls #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hygraph connector now only adds optimizations to the url if they are requested
danielroe
reviewed
Oct 30, 2025
commit: |
danielroe
approved these changes
Oct 30, 2025
Contributor
Author
|
Just fixed the failing test |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
========================================
- Coverage 7.03% 7.03% -0.01%
========================================
Files 77 77
Lines 3567 3570 +3
Branches 138 138
========================================
Hits 251 251
- Misses 3268 3271 +3
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hygraph connector now only adds optimizations to the url if they are requested.
🔗 Linked issue
Fixes #1998
❓ Type of change
📚 Description
This fix modifies the hygraph provider to ensure no broken URLs are being returned from it. Specifically, the hygraph asset transformation API does not accept an empty
resizeparameter in the URL. Calling the provider without a transform will build a URL like this:That is wrong, as hygraph expects the
resize=parameter to have at leastwidthorheightvalues. Otherwise it will throw aBad Requesterror response.This PR only adds the parameter, when there's a transformation going on.