Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Conversation

shrpne
Copy link
Contributor

@shrpne shrpne commented Apr 6, 2020

{ naked: auto } doesn't work
This PR fixes it.

Considerations:

  • maybe I should pass only the naked option and not whole config?
  • core/src/blueprint/index.js, register method doesn't use config in the modeInstances initialization too, should I pass config here? Not sure if it needed for them.

@galvez galvez changed the title fix naked fix: naked option Apr 6, 2020
@galvez galvez requested a review from pimlie April 6, 2020 15:56
@galvez
Copy link
Contributor

galvez commented Apr 6, 2020

@pimlie can you answer on the second point @shrpne raises?

@shrpne
Copy link
Contributor Author

shrpne commented Apr 6, 2020

Looks like config is really needed for modeInstances. Because without it, nuxt-press continues importing blueprint themes like docs/src/theme.css.

I have updated PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants