Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(InputNumber): handle increment / decrement as booleans #4805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 23, 2025
Merged

feat(InputNumber): handle increment / decrement as booleans #4805

merged 22 commits into from
Oct 23, 2025
+239 −80

Conversation

J-Michalek
Copy link
Contributor

🔗 Linked issue

Resolves: #4718

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I added a new props showButtons that add the option to hide the buttons.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@J-Michalek
Copy link
Contributor Author

The wording in the docs could be improved and also I'm not sure about the prop name some alternatives would be hideButtons: boolean, buttons: boolean or perhaps integrate it into the increment and decrement props to allow false to be passed in and hide the button...

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 22, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4805

commit: 739b249

@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
@J-Michalek J-Michalek changed the base branch from v3 to v4 October 13, 2025 04:46
benjamincanac
benjamincanac reviewed Oct 13, 2025
View reviewed changes
@github-actions github-actions bot added the v4 #4488 label Oct 15, 2025
@J-Michalek
Copy link
Contributor Author

@benjamincanac I've addressed #4805 (comment)

I am wondering if we could get rid of incrementDisabled and decrementDisabled props in favor of increment.disabled and decrement.disabled, what do you think?

@benjamincanac
Copy link
Member

I agree it would be better but this would cause a breaking change 😬

@J-Michalek J-Michalek changed the title feat(InputNumber): add showButtons prop feat(InputNumber): add option to hide increment/decrement buttons Oct 15, 2025
benjamincanac
benjamincanac reviewed Oct 17, 2025
View reviewed changes
@benjamincanac benjamincanac marked this pull request as draft October 18, 2025 17:16
@benjamincanac benjamincanac removed the v3 #1289 label Oct 21, 2025
benjamincanac
benjamincanac reviewed Oct 22, 2025
View reviewed changes
benjamincanac
benjamincanac approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J-Michalek I updated the theme to match exactly the one from Input and used the increment and decrement props instead so it's way simpler! Let me know what you think 😊

@benjamincanac benjamincanac marked this pull request as ready for review October 23, 2025 08:36
@benjamincanac benjamincanac changed the title feat(InputNumber): add option to hide increment/decrement buttons feat(InputNumber): handle increment / decrement as booleans Oct 23, 2025
@benjamincanac benjamincanac merged commit 1858908 into nuxt:v4 Oct 23, 2025
16 checks passed
@J-Michalek
Copy link
Contributor Author

Much cleaner, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v4 #4488

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[InputNumber] add option to hide increment/decrement buttons

2 participants

@J-Michalek @benjamincanac