-
Notifications
You must be signed in to change notification settings - Fork 909
fix(Pagination): make ellipsis non-interactive #5081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benjamincanac
merged 6 commits into
nuxt:v4
from
J-Michalek:fix/pagination-ellipsis-a11y
Sep 29, 2025
Merged
fix(Pagination): make ellipsis non-interactive #5081
benjamincanac
merged 6 commits into
nuxt:v4
from
J-Michalek:fix/pagination-ellipsis-a11y
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
</slot> | ||
</PaginationListItem> | ||
|
||
<PaginationEllipsis v-else :key="item.type" :index="index" as-child :class="ui.ellipsis({ class: props.ui?.ellipsis })"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noticing index
on the DOM, it seems the PaginationEllipsis
doesn't take index
prop here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I've removed it.
benjamincanac
approved these changes
Sep 29, 2025
benjamincanac
added a commit
that referenced
this pull request
Oct 2, 2025
Co-authored-by: Jakub <[email protected]> Co-authored-by: Benjamin Canac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
The ellipsis is meant to be a non interactive element and currently it is also a
button
element that can receive focus, but since interacting with it does nothing it doesn't make much sense to be abutton
element. I've changed it to adiv
element - the same approach RekaUI uses in their examples.π Checklist