Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

J-Michalek
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The ellipsis is meant to be a non interactive element and currently it is also a button element that can receive focus, but since interacting with it does nothing it doesn't make much sense to be a button element. I've changed it to a div element - the same approach RekaUI uses in their examples.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 26, 2025

npm i https://pkg.pr.new/@nuxt/ui@5081

commit: 2baf0e5

</slot>
</PaginationListItem>

<PaginationEllipsis v-else :key="item.type" :index="index" as-child :class="ui.ellipsis({ class: props.ui?.ellipsis })">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing index on the DOM, it seems the PaginationEllipsis doesn't take index prop here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I've removed it.

@benjamincanac benjamincanac changed the title fix(Pagination): ellipsis a11y fix(Pagination): improve ellipsis a11y Sep 29, 2025
@benjamincanac benjamincanac changed the title fix(Pagination): improve ellipsis a11y fix(Pagination): make ellipsis non-interactive Sep 29, 2025
@benjamincanac benjamincanac merged commit 62f64cc into nuxt:v4 Sep 29, 2025
15 checks passed
benjamincanac added a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants