fix(App): allow global portal disabling #5111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menthol Would love your review on this since you implemented it 😊 |
commit: |
benjamincanac
commented
Sep 30, 2025
|
|
||
| const disabled = computed(() => typeof portal.value === 'boolean' ? !portal.value : false) | ||
|
|
||
| provide(portalTargetInjectionKey, computed(() => to.value)) |
There was a problem hiding this comment.
@menthol just wondering before merging, why was there a provide in here? 🤔
There was a problem hiding this comment.
The first implementation used usePortal() to fire the provide, but I forgot to remove it from usePortal since we use the symbol directly in App.vue.
benjamincanac
added a commit
that referenced
this pull request
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The goal here is to allow to set
:portal="false"on UApp to disable portals globally.📝 Checklist