Add Eigen 3.4 and image sequence pipeline support #19
+254,971
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HarborC thank you so much for your contribution! I've checked your code changes, and it seems that we've added 254k lines of code which are a bit hard to review. (we have to review a bit carefully even if it's copied due to security reasons). Do you think it is possible to include the library as a Also I would like to understand the background of the errors that you've encountered. By default if you use the |
|
Should we close as this might have already been resolved in #50? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two key enhancements:
Upgrade to Eigen 3.4
The
slam_extmodule requires Eigen 3.4 to function correctly. However, Ubuntu 20.04 and earlier versions ship with Eigen 3.3.x by default, which leads to compilation issues. To ensure compatibility across systems, Eigen 3.4 is now bundled underthirdparty/eigen.Add support for raw image sequence input
A new processing pipeline is added to support image sequence data. Users can now run the system on a directory of images using:
Maybe fix slam pass stuck and not moving #4