Fix issue #862 #864
Closed
Fix issue #862 #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you like the solution with the dictionary i can do the same with Russian language |
nvbn
added a commit
that referenced
this pull request
Jan 14, 2019
commit b853385ea9b9409a29a30c7af4d47c9a500cd287 Author: Vladimir Iakovlev <[email protected]> Date: Tue Jan 15 00:54:01 2019 +0100 #864: Make the solution for Greek a bit more extensible commit 073ebceb594ad24972f7765b1f608de44c1cebf2 Merge: b946b7d 141462a Author: Vladimir Iakovlev <[email protected]> Date: Tue Jan 15 00:46:09 2019 +0100 Merge branch 'master' of git://github.com/RealOgre/thefuck into RealOgre-master commit 141462a Author: RealOrge <[email protected]> Date: Thu Dec 13 16:47:43 2018 +0200 Update switch_lang.py commit 1f79285 Author: RealOrge <[email protected]> Date: Thu Dec 13 16:39:04 2018 +0200 Update switch_lang.py commit e7dede5 Author: RealOrge <[email protected]> Date: Thu Dec 13 15:24:10 2018 +0200 Update switch_lang.py commit 4a0a973 Author: RealOrge <[email protected]> Date: Thu Dec 13 15:04:44 2018 +0200 Update switch_lang.py commit 80d6b8d Author: RealOrge <[email protected]> Date: Thu Dec 13 14:25:15 2018 +0200 Update switch_lang.py commit 66b13c5 Author: RealOrge <[email protected]> Date: Thu Dec 13 11:44:48 2018 +0200 Update switch_lang.py
|
Thanks! I've changed it a bit to make it possible to use similar solution for other languages in the future. Merged manually in 8093f7c |
riley-martine
pushed a commit
to riley-martine/thefuck
that referenced
this pull request
Dec 7, 2023
commit b853385ea9b9409a29a30c7af4d47c9a500cd287 Author: Vladimir Iakovlev <[email protected]> Date: Tue Jan 15 00:54:01 2019 +0100 nvbn#864: Make the solution for Greek a bit more extensible commit 073ebceb594ad24972f7765b1f608de44c1cebf2 Merge: e068b5d 141462a Author: Vladimir Iakovlev <[email protected]> Date: Tue Jan 15 00:46:09 2019 +0100 Merge branch 'master' of git://github.com/RealOgre/thefuck into RealOgre-master commit 141462a Author: RealOrge <[email protected]> Date: Thu Dec 13 16:47:43 2018 +0200 Update switch_lang.py commit 1f79285 Author: RealOrge <[email protected]> Date: Thu Dec 13 16:39:04 2018 +0200 Update switch_lang.py commit e7dede5 Author: RealOrge <[email protected]> Date: Thu Dec 13 15:24:10 2018 +0200 Update switch_lang.py commit 4a0a973 Author: RealOrge <[email protected]> Date: Thu Dec 13 15:04:44 2018 +0200 Update switch_lang.py commit 80d6b8d Author: RealOrge <[email protected]> Date: Thu Dec 13 14:25:15 2018 +0200 Update switch_lang.py commit 66b13c5 Author: RealOrge <[email protected]> Date: Thu Dec 13 11:44:48 2018 +0200 Update switch_lang.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a dictionary that correlates a Greek character to the appropriate English character. Some of the symbols are not in the dictionary like the " " and "-" but because this two characters are at the same position between the keyboards so no correlation is needed.
The code had no errors when i run py.test.
I can provide more information or extra work, if deems necessary.