Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shiralal
Copy link
Contributor

Added dnt_phrases parameter in translation_config.

@rmittal-github rmittal-github changed the base branch from main to release/2.17.0 August 23, 2024 03:56
@rmittal-github
Copy link
Contributor

@shiralal please rebase on top of release/2.17.0 branch, since it is targeted for upcoming release.

@shiralal shiralal force-pushed the add-dnt-support-in-s2s branch from 2df3e2c to 20ce617 Compare August 23, 2024 09:37
@shiralal
Copy link
Contributor Author

@shiralal please rebase on top of release/2.17.0 branch, since it is targeted for upcoming release.

rebased on release/2.17.0 branch

@shiralal shiralal force-pushed the add-dnt-support-in-s2s branch from 20ce617 to 0c25d46 Compare August 27, 2024 20:17
Copy link
Contributor

@rmittal-github rmittal-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for CI to complete before merge

@shiralal shiralal force-pushed the add-dnt-support-in-s2s branch from 0c25d46 to 947848d Compare August 28, 2024 10:14
@rmittal-github rmittal-github merged commit a7d342c into nvidia-riva:release/2.17.0 Aug 28, 2024
rmittal-github added a commit that referenced this pull request Sep 30, 2024
* Update field description to list s2s/s2t languages (#39)

* Add DNT (do not translate) phrases field for NMT (#38)

---------

Co-authored-by: shiralal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants