Revert %s-formatting for SOURCE_STR when writing to shell profile#1210
Merged
ljharb merged 1 commit intonvm-sh:masterfrom Aug 23, 2016
aredridel:fix-install-sh
Merged
Revert %s-formatting for SOURCE_STR when writing to shell profile#1210ljharb merged 1 commit intonvm-sh:masterfrom aredridel:fix-install-sh
ljharb merged 1 commit intonvm-sh:masterfrom
aredridel:fix-install-sh
Conversation
Member
|
aha, thanks |
Contributor
Author
|
Of course! |
| if ! command grep -qc '/nvm.sh' "${NVM_PROFILE}"; then | ||
| echo "=> Appending source string to ${NVM_PROFILE}" | ||
| command printf "%s" "${SOURCE_STR}" >> "${NVM_PROFILE}" | ||
| if ! command grep -qc '/nvm.sh' "$NVM_PROFILE"; then |
Member
There was a problem hiding this comment.
do the curlies make a difference? or are you just reverting the whole commit
Contributor
Author
There was a problem hiding this comment.
The curlies don't matter -- either syntax is legit.
Member
|
This reverts part of 681c81a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209