Conversation
ljharb
requested changes
Sep 28, 2016
Member
ljharb
left a comment
There was a problem hiding this comment.
Thanks! This does require a few additional test changes.
Typically I don't update the test mocks unless there's a reason - ie, i've altered the formatting of some of the outputs, or added LTS - or in the future when a non-Argon LTS is available.
It's fine to update at any time though :-)
358434c to
702d52f
Compare
Collaborator
Author
|
Oops, now it pass the test! |
ljharb
approved these changes
Sep 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important security releases just been released about 7 hours ago, I think it's better to send a PR instead of just create an issue to ask for the update 👍