Codestin Search App

PeterDaveHello · 2016-11-13T21:40:52Z

Fixes #902.

PeterDaveHello · 2016-11-14T04:06:49Z

Looks like we need clang v3.5+

PeterDaveHello · 2016-11-14T04:11:55Z

Looks like clang version output may have different format:

Ubuntu 14.04:

Ubuntu clang version 3.4-1ubuntu3 (tags/RELEASE_34/final) (based on LLVM 3.4)
Target: x86_64-pc-linux-gnu
Thread model: posix

Ubuntu 15.04:

Ubuntu clang version 3.6.0-2ubuntu1 (tags/RELEASE_360/final) (based on LLVM 3.6.0)
Target: x86_64-pc-linux-gnu
Thread model: posix

Ubuntu 16.04:

clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

FreeBSD 10.3:

FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512
Target: x86_64-unknown-freebsd10.3
Thread model: posix

ArchLinux:

clang version 3.9.0 (tags/RELEASE_390/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/sbin

Debian 8.6:

Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
Target: x86_64-pc-linux-gnu
Thread model: posix

ljharb · 2016-11-14T07:34:42Z

.travis.yml

+  - clang --version
+  - clang++ --version
  - if [ -n "${SHELLCHECK-}" ]; then sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 575159689BEFB442 && echo 'deb http://download.fpcomplete.com/ubuntu precise main' | sudo tee /etc/apt/sources.list.d/fpco.list && sudo apt-get update && sudo apt-get install stack bc -y && stack setup && stack install ShellCheck && shellcheck --version ; fi
+  - if [ -z "${SHELLCHECK-}" ]; then wget -O - http://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add - && echo -e "deb http://apt.llvm.org/precise/ llvm-toolchain-precise main\ndeb http://apt.llvm.org/precise/ llvm-toolchain-precise-3.8 main" | sudo tee /etc/apt/sources.list.d/clang.list && sudo apt-get update && sudo apt-get install clang-3.8 lldb-3.8 -y --force-yes && sudo ln -sf /usr/bin/clang-3.8 /usr/bin/clang && sudo ln -sf /usr/bin/clang++-3.8 /usr/bin/clang++ && clang --version ; fi


are these not things that can be installed by travis in the "addons: apt" section above?

clang in Ubuntu 12.04 is too old ( < v3.5)

Will this installation process be cached, like the shellcheck build is?

I don't think so, do we have cache on the apt packages?

Yes - https://github.com/creationix/nvm/blob/master/.travis.yml#L12-L15

I think this only cache the ~/.stack, not the package in system level, am I right?

The shellcheck build is very very slow, and once the first one was built, it didn't need to be rebuilt on successive builds.

I want to ensure that we don't need to build clang more than the once.

We install clang from binary, no build needed.

ah ok, that's good. is caching the download worth it?

I don't think so, as the time will be mainly used to solve the dependencies, not on the package downloading.

ljharb · 2016-11-14T07:35:07Z

nvm.sh

  fi
 }

+nvm_clang_version() {


let's add some unit tests for this

@ljharb where should I put the test script? Thanks.

test/fast/Unit Tests

ljharb · 2016-11-14T07:35:18Z

nvm.sh

  elif [ "${NVM_OS}" = 'aix' ]; then
    make='gmake'
  fi
+  if nvm_has "clang++" && nvm_has "clang" && nvm_version_greater_than_or_equal_to nvm_clang_version 3.5 ; then


are both clang and clang++ needed?

I guess so: https://github.com/nodejs/node/blob/master/BUILDING.md#unix--os-x

PeterDaveHello · 2016-11-14T18:55:51Z

@ljharb I think we are good to go now 😄

[New] `nvm install -s`: Use clang as C/C++ compiler if detected Fixes nvm-sh#902

PeterDaveHello added 2 commits November 14, 2016 05:39

[New] nvm install -s: Use clang as C/C++ compiler if detected.

38934bf

Fixes nvm-sh#902.

[Tests] Upgrade clang from llvm in Travis-ci

9f67d3e

Add nvm_clang_version to ensure clang version > 3.5

65acb40

PeterDaveHello force-pushed the clang-llvm branch 8 times, most recently from 05b0bc7 to 7e9e2ca Compare November 14, 2016 07:14

ljharb reviewed Nov 14, 2016

View reviewed changes

ljharb added feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions. labels Nov 14, 2016

PeterDaveHello force-pushed the clang-llvm branch 6 times, most recently from e96cd9b to f6d8f04 Compare November 14, 2016 17:41

PeterDaveHello force-pushed the clang-llvm branch from f6d8f04 to a6f95db Compare November 16, 2016 13:06

ljharb force-pushed the clang-llvm branch from a6f95db to 65acb40 Compare November 17, 2016 07:38

ljharb merged commit ab6be9c into nvm-sh:master Nov 17, 2016

PeterDaveHello deleted the clang-llvm branch November 17, 2016 08:19

edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018

Merge pull request nvm-sh#1300 from PeterDaveHello/clang-llvm

23cb938

[New] `nvm install -s`: Use clang as C/C++ compiler if detected Fixes nvm-sh#902

Uh oh!

Comments

Conversation

PeterDaveHello commented Nov 13, 2016 • edited by ljharb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PeterDaveHello commented Nov 14, 2016

Uh oh!

PeterDaveHello commented Nov 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PeterDaveHello commented Nov 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PeterDaveHello commented Nov 13, 2016 •

edited by ljharb

Loading

PeterDaveHello commented Nov 14, 2016 •

edited

Loading