Only nvm install if we can't nvm use#1378
Merged
ljharb merged 1 commit intonvm-sh:masterfrom Jan 5, 2017
Merged
Conversation
ljharb
requested changes
Jan 4, 2017
README.markdown
Outdated
|
|
||
| if [ "$nvmrc_node_version" != "N/A" ] && [ "$nvmrc_node_version" != "$node_version" ]; then | ||
| if [ "$nvmrc_node_version" != "N/A" ]; then | ||
| [ "$nvmrc_node_version" != "$node_version" ] && nvm use |
Member
There was a problem hiding this comment.
Let's use an if here instead of &&, or else it'll run afoul of set -e
337984d to
5f5bdd7
Compare
Contributor
Author
|
Yeah, sorry, it is a duplicate as #1357. I missed that. Although this doesn't have the unnecessary extra if condition. |
Contributor
Author
|
Just FYI, auto use implementation is completed in |
ljharb
approved these changes
Jan 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1377