Merged
Conversation
ljharb
reviewed
Mar 22, 2017
Member
ljharb
left a comment
There was a problem hiding this comment.
Thanks, LGTM pending one wording comment
CONTRIBUTING.md
Outdated
|
|
||
| For bug reports: | ||
| - Please make sure the bug is reproducible, and give us the steps to reproduce it, so that we can dig into the problem. | ||
| - Please give us the info about your environments as detail as possible, so that we can confirm the problem easier. |
Member
There was a problem hiding this comment.
"Please give us as much detail as possible about your environment, so we can more easily confirm the problem"
Collaborator
Author
There was a problem hiding this comment.
Updated, thanks.
b42e1ac to
89ec24a
Compare
ljharb
approved these changes
Mar 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The origin one looks like it's for PR only, let's add something about the issue?