Conversation
Makefile
Outdated
| endif | ||
|
|
||
| # Ensures there are version tags in repository | ||
| .PHONE: _ensure-current-version |
There was a problem hiding this comment.
typo ... lol
8b90b55 to
d02ea3d
Compare
|
I'm confused; does this just test that |
|
Currently yes, at least it'll catch #1492, I'm not sure what kind of behavior here you expect here? |
|
I guess ensuring that the old version number is completely replaced would be nice :-) |
|
How would you like to do it? Simply |
|
:-/ I'm not really sure what the best approach is. |
|
I don't think we need to reach a perfect or very very good status each time ... actually it's good enough to catch some potential problems already, like #1492, and the other tests are not perfect either, we can just keep making it better. |
|
|
||
| # Ensures there are version tags in repository | ||
| .PHONE: _ensure-current-version | ||
| .PHONY: _ensure-current-version |
There was a problem hiding this comment.
i think this change belongs to the other commit?
There was a problem hiding this comment.
Too tired, thanks for catching!
d02ea3d to
5a9e258
Compare
.travis.yml
Outdated
| - PATH="~/.cabal/bin/:$(echo $PATH | sed 's/::/:/')" | ||
| - NVM_DIR="${TRAVIS_BUILD_DIR}" | ||
| matrix: | ||
| - MAKE_RELEASE=true GIT_EDITOR="sed -i '1 s/^/99.99.99 make release test/'" |
There was a problem hiding this comment.
could we move the GIT_EDITOR var to the script command instead of in the matrix?
5a9e258 to
229c7e6
Compare
Can help detect one more problem in #1492 and make sure Makefile changes won't break release process!