Merged
Conversation
ljharb
approved these changes
Jun 26, 2017
Member
ljharb
left a comment
There was a problem hiding this comment.
This is good as-is, however - it'd be nice to tweak it further, since the bash_profile comments are specific to OS X.
Maybe adding a separate note higher up that duplicates the "restart your terminal" instructions?
ljharb
approved these changes
Jun 26, 2017
Member
ljharb
left a comment
There was a problem hiding this comment.
Thanks, looks great!
If you don't get to the one comment before I do, I'll fix it as part of merging. Appreciate the help!
README.md
Outdated
| ```sh | ||
| command -v nvm | ||
| ``` | ||
| simply close your current terminal, open a new terminal and try verifying again. |
Member
There was a problem hiding this comment.
needs an oxford comma after "terminal" :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added this for Linux users who may skip over the bit of information because it looks like it pertained only to OS X. Most developers will know about reopening the terminal window, but noobs don't. ;-)
Fixes #1565