[Refactor] nvm.sh: make coding style more consistent
#1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
May 24, 2018
35e6e7a to
800cac2
Compare
|
@ljharb hope this looks good now :) |
ljharb
reviewed
Dec 30, 2018
800cac2 to
0f7ea59
Compare
ljharb
reviewed
Dec 31, 2018
0f7ea59 to
7d137a0
Compare
|
Updated. |
ljharb
approved these changes
Jan 21, 2019
nvm.sh: Improve coding stylenvm.sh: make coding style more consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ }to variable referencecaseand some multi-line commands;do and; thenon the same line as thewhile,fororif.;of single line commandsReferences:
The
sh/shfmttool can't be integrated with CI yet as there are some styles can't be customized and the changes are too many, so just use it as a reference, helper currently, the fixes are still made by myself.