fix for .nvmrc script #1823
Merged
fix for .nvmrc script #1823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a revert of #1821; @sidsakhadeo, can you and @SrHuevo hash this out? |
|
Hi @SrHuevo, can you elaborate on what's not working for you? I've tried the script for the case when the if [ "$nvmrc_node_version" = "N/A" ]; then
nvm install |
|
That would only happen if it’s not installed; but if it’s installed but different than the current one? |
|
I think you're right. I apologize for the bad PR. However, the case where its installed and needs to be used would still be missed. If you want to go ahead and merge this PR, I can work on fixing it later. |
ljharb
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script isn't working if .nvmrc file had a diferent version of node