Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Fix] Improve syntax in "test/installation_iojs/nvm install v1 works" #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

[Fix] Improve syntax in "test/installation_iojs/nvm install v1 works" #1990

merged 1 commit into from
Jan 22, 2019

Conversation

@PeterDaveHello
Copy link
Collaborator

@PeterDaveHello PeterDaveHello commented Jan 22, 2019

Double quote to prevent globbing and word splitting.

Found the syntax issue caused by that when writing tests for #1989

ljharb
ljharb approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ljharb ljharb merged commit 7e715d5 into nvm-sh:master Jan 22, 2019
@PeterDaveHello PeterDaveHello deleted the fix-iojs-test branch January 23, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PeterDaveHello @ljharb