Thanks to visit codestin.com
Credit goes to github.com

Skip to content

input type=file may be dangerous #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ondra-novak wants to merge 1 commit into from
Closed

input type=file may be dangerous #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Source/core/fileapi/File.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,4 @@
[MeasureAs=FileGetLastModifiedDate] readonly attribute Date lastModifiedDate;
readonly attribute long long lastModified;
[MeasureAs=PrefixedFileRelativePath] readonly attribute DOMString webkitRelativePath;
readonly attribute DOMString path;
};
20 changes: 0 additions & 20 deletions Source/core/html/HTMLInputElement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,26 +1705,6 @@ bool HTMLInputElement::shouldAppearIndeterminate() const
return m_inputType->supportsIndeterminateAppearance() && indeterminate();
}

String HTMLInputElement::nwworkingdir() const
{
return fastGetAttribute(nwworkingdirAttr);
}

void HTMLInputElement::setNwworkingdir(const String& value)
{
setAttribute(nwworkingdirAttr, AtomicString(value));
}

String HTMLInputElement::nwsaveas() const
{
return fastGetAttribute(nwsaveasAttr);
}

void HTMLInputElement::setNwsaveas(const String& value)
{
setAttribute(nwsaveasAttr, AtomicString(value));
}

bool HTMLInputElement::isInRequiredRadioButtonGroup()
{
ASSERT(isRadioButton());
Expand Down
6 changes: 0 additions & 6 deletions Source/core/html/HTMLInputElement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,12 +237,6 @@ class HTMLInputElement : public HTMLTextFormControlElement {

String defaultToolTip() const;

String nwworkingdir() const;
void setNwworkingdir(const String& value);

String nwsaveas() const;
void setNwsaveas(const String& value);

static const int maximumLength;

unsigned height() const;
Expand Down
4 changes: 0 additions & 4 deletions Source/core/html/HTMLInputElement.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,7 @@ interface HTMLInputElement : HTMLElement {
// Non-standard attributes
[Reflect, MeasureAs=PrefixedDirectoryAttribute] attribute boolean webkitdirectory;
[Reflect, MeasureAs=IncrementalAttribute] attribute boolean incremental;
[Reflect] attribute boolean nwdirectory;

// See http://www.w3.org/TR/html-media-capture/
[RuntimeEnabled=MediaCapture, Reflect] attribute boolean capture;

attribute DOMString nwworkingdir;
attribute DOMString nwsaveas;
};
13 changes: 4 additions & 9 deletions Source/core/html/forms/FileInputType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,9 @@ void FileInputType::handleDOMActivateEvent(Event* event)
settings.acceptFileExtensions = input.acceptFileExtensions();
settings.selectedFiles = m_fileList->pathsForUserVisibleFiles();
settings.useMediaCapture = RuntimeEnabledFeatures::mediaCaptureEnabled() && input.isFileUpload() && input.fastHasAttribute(captureAttr);
settings.directoryChooser = input.fastHasAttribute(nwdirectoryAttr);
settings.saveAs = input.fastHasAttribute(nwsaveasAttr);
settings.directoryChooser = false;
settings.saveAs = false;

settings.initialPath = input.nwworkingdir();
settings.initialValue = input.nwsaveas();
chrome->runOpenPanel(input.document().frame(), newFileChooser(settings));
}
event->setDefaultHandled();
Expand All @@ -178,7 +176,7 @@ RenderObject* FileInputType::createRenderer(RenderStyle*) const

bool FileInputType::canSetStringValue() const
{
return true;
return false;
}

FileList* FileInputType::files()
Expand Down Expand Up @@ -208,10 +206,7 @@ bool FileInputType::getTypeSpecificValue(String& value)
// decided to try to parse the value by looking for backslashes
// (because that's what Windows file paths use). To be compatible
// with that code, we make up a fake path for the file.
unsigned numFiles = m_fileList->length();
value = m_fileList->item(0)->path();
for (unsigned i = 1; i < numFiles; ++i)
value.append(String(";") + m_fileList->item(i)->path());
value = "C:\\fakepath\\" + m_fileList->item(0)->name();
return true;
}

Expand Down
4 changes: 0 additions & 4 deletions Source/platform/UserGestureIndicator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,7 @@ bool UserGestureIndicator::processingUserGesture()
{
if (!isMainThread())
return false;
#if 0
return s_topmostIndicator && static_cast<GestureToken*>(s_topmostIndicator->currentToken())->hasGestures() && (s_state == DefinitelyProcessingNewUserGesture || s_state == DefinitelyProcessingUserGesture);
#endif
//Enable scripts to emulate all kinds of user gesture
return true;
}

bool UserGestureIndicator::consumeUserGesture()
Expand Down