ScriptState used by EventListener::handleEvent() is wrong #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL is a revert of r175241 (which was landed 6 months ago), essentially. Currently an event listener is fired in a ScriptState that installed the event listener, but this is wrong. An event listener must be fired in a ScriptState that is calculated based on the ExecutionContext that fired the event listener and the world that installed the event listener. This is what we had been doing before r175241, and this CL restores the behavior. See an added test case for more details. The new behavior aligns with the spec and Firefox. One tricky part is how to handle a beforeunload event. A return value of a beforeunload event needs to be fired in a ScriptState that installed the beforeunload event listener. To achieve the behavior, this CL records the ScriptState onto V8AbstractEventListener::m_scriptStateForBeforeUnload. BUG=422227 TEST=event-should-be-dispatched-for-correct-frame.html,before-unload-return-bad-value.html Review URL: https://codereview.chromium.org/823263002 git-svn-id: svn://svn.chromium.org/blink/trunk@187861 bbb929c8-8fbe-4397-9dbb-9b2b20218538 Conflicts: Source/bindings/core/v8/V8AbstractEventListener.cpp Source/bindings/core/v8/V8AbstractEventListener.h Source/bindings/core/v8/V8ErrorHandler.h Source/bindings/core/v8/V8EventListener.h Source/bindings/core/v8/V8LazyEventListener.cpp Source/bindings/core/v8/V8LazyEventListener.h Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h Source/core/xml/DocumentXSLT.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL is a revert of r175241 (which was landed 6 months ago), essentially.
Currently an event listener is fired in a ScriptState that installed the event listener, but this is wrong. An event listener must be fired in a ScriptState that is calculated based on the ExecutionContext that fired the event listener and the world that installed the event listener. This is what we had been doing before r175241, and this CL restores the behavior. See an added test case for more details. The new behavior aligns with the spec and Firefox.
One tricky part is how to handle a beforeunload event. A return value of a beforeunload event needs to be fired in a ScriptState that installed the beforeunload event listener. To achieve the behavior, this CL records the ScriptState onto V8AbstractEventListener::m_scriptStateForBeforeUnload.
BUG=422227
TEST=event-should-be-dispatched-for-correct-frame.html,before-unload-return-bad-value.html
Review URL: https://codereview.chromium.org/823263002
git-svn-id: svn://svn.chromium.org/blink/trunk@187861 bbb929c8-8fbe-4397-9dbb-9b2b20218538