Fix of uncaughtException should not catch browser exception #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that's an unsafe assumption. It's assuming the browser context doesn't have critical processes for app operation. If it only catches Node context, then how do you catch for all uncaught exceptions, regardless of context? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node.js, error caught by
uncaughtExceptionmeans application crash. But errors generated by libraries written for browser doesn't. Usually user can ignore those browser generated errors.This patch only forward exceptions created in node context to
uncaughtException(fix nwjs/nw.js#3061).Limitation: non-object exceptions will not be passed to
uncaughtExceptionsince I can't tell if a number or a boolean is generated from node context