[libuuu wrapper] Improve version handling and build robustness #493
+68
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Jaros <[email protected]>
Signed-off-by: Tomas Jaros <[email protected]>
Signed-off-by: Tomas Jaros <[email protected]>
nxpfrankli
reviewed
Oct 27, 2025
nxpfrankli
reviewed
Oct 27, 2025
| run: | | ||
| git status | ||
| - name: Upload wheels |
There was a problem hiding this comment.
why need run git staus, look likes debug code.
nxpfrankli
reviewed
Oct 27, 2025
nxpfrankli
reviewed
Oct 27, 2025
| ver = lib.get_version() | ||
| assert isinstance(ver, int) | ||
|
|
||
|
|
There was a problem hiding this comment.
One empty line is enough, remove line 162 also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix version generation reliability issues and add missing test coverage.