Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mattgrunwald
Copy link
Contributor

Did you update the tests?

  • yes
  • no
  • n/a

Did you update the docs?

  • yes
  • no
  • n/a

The cooking grocery lists service is a GAE app that until recently ran on go v1.16. Yesterday I found out that GAE no longer supports go v1.16 at all, and requires restructuring our repo a little bit to accommodate other changes to upgrade to v1.18. Our other option is to downgrade to v1.15 👎

Using v1.18 is in preview mode and requires gcloud cli version 417.0.1 or later

Copy link
Member

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for raising this Matt.

We'll need to tag a v0.3.0 release for this as I'm not sure about the sdk compatibility with the deprecated appcfg tooling.

@mattgrunwald
Copy link
Contributor Author

@tonglil Sounds good. I won't be able to merge or tag anything in this though

@prathameshnyt prathameshnyt merged commit 68a8fc3 into nytimes:main Feb 28, 2023
@prathameshnyt
Copy link
Contributor

prathameshnyt commented Feb 28, 2023

Thanks, @mattgrunwald I have tagged 0.3.0 release.

@mattgrunwald mattgrunwald deleted the mg-update-base-image branch February 28, 2023 17:02
tonglil added a commit that referenced this pull request Mar 1, 2023
@tonglil
Copy link
Member

tonglil commented Mar 1, 2023

Hi @mattgrunwald, unfortunately due to incompatible changes being introduced with the sdk upgrade, we had to revert this PR.

Before upgrading the sdk any further, the plugin should be migrated off of using appcfg. I believe this is possible without introducing a breaking change as the drone plugin parameter interface can abstract the changes from the user.

The issue that was identified was this:

Running Command: /go_appengine/appcfg.py  --oauth2_access_token  [redacted] 

 -A redacted -V 64c97e9638b4e0c7939751ee26cef8c120f6643f update_dispatch .

/usr/bin/env: 'python': No such file or directory

error: exit status 127

I'm hesitant to introduce a potential stopgap of adding or configuring python because this simply propagates the usage of the no longer supported usage of appcfg (see here).

July 30, 2019

The AppCfg tooling and the legacy standalone App Engine SDK, delivered through the GoogleAppEngineLauncher.dmg, GoogleAppEngine.msi, and google_appengine.zip files, are now deprecated. Google will shut down and remove support on July 30, 2020.

The functionalities of the App Engine SDK is delivered exclusively through [Cloud SDK](https://cloud.google.com/sdk/docs). For more information, see [Migrating to Cloud SDK](https://cloud.google.com/appengine/docs/standard/java/sdk-gcloud-migration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants