Fix interface resolution & use def-cycles #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good! I'll run this version on the F Prime code that I am developing and confirm that it fixes the issue. |
Collaborator
|
Thanks for the quick turnaround! |
bocchino
approved these changes
Oct 2, 2025
Collaborator
bocchino
left a comment
There was a problem hiding this comment.
Looks good! I confirmed that it fixes the issue in the F Prime code that I am developing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three missing tests:
ok.fpp)Updated the wiki here https://github.com/nasa/fpp/wiki/Check-Interface-Definitions/4b8dbc9ad330fb4787e356badb86f6889dd36b1b
Fixes #829