Dictionary definitions #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec updates for dictionary specifier
* Store the Ast node in the map * Report the location of the Ast node when the 'dictionary' specifier is inconsistent
Add tests
Dictionary specifier syntax, semantics, and tests
User guide updates for dictionary specifier
Kronos3
reviewed
Nov 3, 2025
Kronos3
reviewed
Nov 3, 2025
compiler/tools/fpp-to-dict/test/top/QualifiedCompInstTopologyDictionary.ref.json
Show resolved
Hide resolved
Kronos3
reviewed
Nov 3, 2025
Kronos3
approved these changes
Nov 3, 2025
Collaborator
Kronos3
left a comment
There was a problem hiding this comment.
This looks great! I just had a minor comment on the users guide.
Include constant symbols used in enum default values
jwest115
approved these changes
Nov 4, 2025
Collaborator
jwest115
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dictionary definitions. Closes #762.