examples/raylib: fix build in Ubuntu Linux 24 (GCC 13.3.0) #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
or add -DCMAKE_C_FLAGS="-D_GNU_SOURCE" to cmake (then patch the readme file instead), you decide |
|
@gabrielssanches thank you. I don't think we should change the C standard as nbnet is intended to be a C99 library. |
gcc 13.3.0 spits out errors regaring timespec:
```
nbnet/examples/raylib/server.c:404:16: error: variable ‘t’ has initializer but incomplete type
404 | struct timespec t = {.tv_sec = nanos / 999999999, .tv_nsec = nanos % 999999999};
| ^~~~~~~~
```
c99 includes time.h but timespec is not added automatically
Signed-off-by: Gabriel dos Santos Sanches <[email protected]>
compilation breaks (gcc 13.3.0 in Ubuntu 24) due to missing header
inclusion:
```
nbnet/examples/raylib/server.c:303:5: warning: implicit declaration of function ‘signal’; did you mean ‘sinhl’? [-Wimplicit-function-declaration]
303 | signal(SIGINT, SigintHandler);
| ^~~~~~
| sinhl
nbnet/examples/raylib/server.c:303:12: error: ‘SIGINT’ undeclared (first use in this function)
303 | signal(SIGINT, SigintHandler);
| ^~~~~~
```
Signed-off-by: Gabriel dos Santos Sanches <[email protected]>
b62786d to
f88fbf2
Compare
|
changes made |
|
@gabrielssanches thank you. Looks like some pipeline jobs are failing, but it seems to be due to CMake and Python deprecation. I'll fix those in master and rerun the pipeline in this MR and merge whell they all pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 13.3.0 spits out errors regaring timespec:
c99 includes time.h but timespec is not added automatically
changing the C standar from c99 to gnu99 fix this issue