-
Notifications
You must be signed in to change notification settings - Fork 38
Consolidates projects and prepares for AZ DevOps #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidates projects and prepares for AZ DevOps #143
Conversation
Changes: - Uses same folder structure as NATS.Client - Strong naming as NATS.Client - Cleans test utils as we do not have config - Fixes some tests that were comparing local against UTC times
These tests interfere with each other. If you run both then TestPublishReconnectDeadlock fails. Cleaning up solves the issue.
This to overcome the issue of NATS not being strong named before that.
This is an issue as we check it for null to determine if closed in other parts of the client.
Removes build status. Will be replaced once in Azure.
|
@ColinSullivan1 When merged to |
| <PackageReference Include="Google.Protobuf" Version="3.10.0" /> | ||
| <PackageReference Include="Google.Protobuf.Tools" Version="3.10.0" PrivateAssets="All" /> | ||
| <PackageReference Include="NATS.Client" Version="0.9.0" /> | ||
| <PackageReference Include="NATS.Client" Version="0.9.1-pre1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColinSullivan1 Had to update to latest pre-rel of NATS as that one is signed. Or should not STAN.Client be signed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now - we can get an official release out for core NATS, then release another version of STAN.
| } | ||
|
|
||
| [Fact] | ||
| [Fact(Skip = "HANGS SOMETIMES")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColinSullivan1 Do you have any ideas why this one is hanging sometimes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't, it works well locally, but seems to hang up in AppVeyor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes:
pingTimerTestPublishReconnectDeadlock)