Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danielwertheim
Copy link
Contributor

Changes:

  • Uses same folder structure as NATS.Client
  • Adds AZ DevOps pipeline
  • Strong naming as NATS.Client (required update to v0.9.1-pre1 of NATS as that is the only one currently signed)
  • Fixes issue with pingTimer
  • Fixes some tests that were comparing local against UTC times
  • Fixes some test clean ups
  • Fixes tests that were interfering with each other (TestPublishReconnectDeadlock)
  • Cleans test utils as we do not have config
  • Updates ReadMe to reflect new changes

Changes:
  - Uses same folder structure as NATS.Client
  - Strong naming as NATS.Client
  - Cleans test utils as we do not have config
  - Fixes some tests that were comparing local against UTC times
These tests interfere with each other. If you run both then
TestPublishReconnectDeadlock fails. Cleaning up solves the issue.
This to overcome the issue of NATS not being strong named before that.
This is an issue as we check it for null to determine if closed in
other parts of the client.
Removes build status. Will be replaced once in Azure.
@danielwertheim
Copy link
Contributor Author

@ColinSullivan1 When merged to master I'll setup a pipeline for it and include the build status link in the ReadMe. The included pipeline definition has been tested to work: https://dev.azure.com/danielwertheim/nats/_build/results?buildId=278&view=results

<PackageReference Include="Google.Protobuf" Version="3.10.0" />
<PackageReference Include="Google.Protobuf.Tools" Version="3.10.0" PrivateAssets="All" />
<PackageReference Include="NATS.Client" Version="0.9.0" />
<PackageReference Include="NATS.Client" Version="0.9.1-pre1" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColinSullivan1 Had to update to latest pre-rel of NATS as that one is signed. Or should not STAN.Client be signed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now - we can get an official release out for core NATS, then release another version of STAN.

}

[Fact]
[Fact(Skip = "HANGS SOMETIMES")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColinSullivan1 Do you have any ideas why this one is hanging sometimes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't, it works well locally, but seems to hang up in AppVeyor.

@ColinSullivan1 ColinSullivan1 merged commit 41c2e68 into nats-io:master Oct 23, 2019
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielwertheim danielwertheim deleted the consolidate_and_ci branch October 24, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants