Support for 3-vector in xyzmatrix.default #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jefferis
commented
Jan 7, 2022
- I have done this in many places where I use xyzmatrix, so probably should have changed long ago ...
- also added better error message wxen we don't managed to make and Nx3 matrix
- includes test
* I have done this in many places where I use xyzmatrix, so probably should have changed long ago ... * also added better error message wxen we don't managed to make and Nx3 matrix * includes test
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 75.68% 75.69% +0.01%
==========================================
Files 48 48
Lines 5893 5897 +4
==========================================
+ Hits 4460 4464 +4
Misses 1433 1433
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.