Improve relationship filter(s) validation in clean() method #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathanism
reviewed
May 12, 2021
Contributor
jathanism
left a comment
There was a problem hiding this comment.
Just nitpicking naming of variables here to be consistent with multi-words (improving readability).
Co-authored-by: Glenn Matthews <[email protected]>
glennmatthews
approved these changes
May 24, 2021
jathanism
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #396
This PR improves how we are validating the
source_filteranddestination_filterin a Relationship object during clean() by loading the value of the filter in the right filterset. Any error reported by the filterset will raise a ValidationError.In the process I had to fix some unit tests that were using non valid parameters