Fixes inability to define the field_order in jobs. #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
glennmatthews
left a comment
There was a problem hiding this comment.
Looks like a good and straightforward fix/enhancement - thank you!
Since _commit is automatically added to the form fields, the job author may not think to include it in field_order - when we call order_fields, what happens to fields that aren't in the list, do they get sent to the start or the end of the form?
It would be nice to add a quick test or two for as_form() with and without a specified field_order, if you're up for doing that.
Contributor
Author
|
Per Django Docs, anything not provided by field_order would be appended to the bottom per the default order that Django would decide. https://docs.djangoproject.com/en/3.2/ref/forms/api/#django.forms.Form.field_order I will see what I can do about tests. |
Co-authored-by: Glenn Matthews <[email protected]>
Co-authored-by: Glenn Matthews <[email protected]>
…correct_job_order
# Conflicts: # nautobot/docs/release-notes/version-1.0.md
Co-authored-by: Glenn Matthews <[email protected]>
# Conflicts: # nautobot/docs/release-notes/version-1.0.md
jathanism
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #459
Fixes the field_order Meta option to jobs.
I can add tests for these, I noticed none of the tests for Jobs tested any of the optional attributes (Name, Description, Commit_Default). We might want to make that a followup ticket...