Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(persist): add IE8 exception handling #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2016
Merged

fix(persist): add IE8 exception handling #235

merged 1 commit into from
May 26, 2016

Conversation

@happyhj
Copy link
Contributor

@happyhj happyhj commented May 26, 2016 •
edited
Loading

Issue

#233
#234

Details

  • Replace cached location with global.location
  • Add try catch block on storage.getItem() in isStorageAvailable method

Preferred reviewers

@sculove, @jongmoon

@happyhj
fix(persist): add IE8 exception handling
821d405 
replace cached location with global.location
Add try catch block on storage.getItem() in isStorageAvailable method

ref naver#233
ref naver#234
@happyhj happyhj added this to the 1.2.0 milestone May 26, 2016
@sculove
Copy link
Contributor

sculove commented May 26, 2016

LGTM

@jongmoon
Copy link
Contributor

jongmoon commented May 26, 2016

LGTM!

@happyhj happyhj merged commit 096af9e into naver:master May 26, 2016
malangfox pushed a commit that referenced this pull request Jan 6, 2025
@sculove
Merge pull request #235 from egjs/changeVersion#233
0515970 
chore(Gruntfile) : fix to change __VERSION__ to current version
malangfox pushed a commit that referenced this pull request Jan 6, 2025
@happyhj
fix(persist): add IE8 exception handling (#235)
f9ce125 
replace cached location with global.location
Add try catch block on storage.getItem() in isStorageAvailable method

fix #233
fix #234
close #235
malangfox pushed a commit that referenced this pull request Jan 7, 2025
@happyhj
fix(persist): add IE8 exception handling (#235)
3e80269 
replace cached location with global.location
Add try catch block on storage.getItem() in isStorageAvailable method

fix #233
fix #234
close #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

persist

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@happyhj @sculove @jongmoon