Ether delayed gas check #301
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sending Ethereum transaction, don't poll the server to check if transaction is out of gas. Eth transactions can now take longer time to be confirmed and that poll could time out. Instead, check if recipient is a contract address. If it is, raise an exception (as sending to contract addresses is not yet supported).
|
I know that it was me giving the suggestion that you create a draft PR, but I can forget why, so please make it clear why it's still a draft PR. |
|
PS: Wait, in telegram you said it's done, then why do I see a WIP commit here? |
It's not tested, so I haven't removed "WIP" prefix yet. |
|
WIP is not for untested stuff. WIP is when you know for sure that the commit is not finished. |
|
DRAFT is to indicate it is not tested. |
When sending Ethereum transaction, don't wait for confirmation, but instead save the transaction as unconfirmed. When showing balances, check for confirmation of unconfirmed transactions and if any of those ran out of gas, and notify user.
c56728b to
6ba0df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sending Ethereum transaction, don't poll the server to
check if transaction is out of gas.
Instead, check if recipient is a contract address.
And when showing balances check check for confirmation of unconfirmed Ethereum txs.