Thanks to visit codestin.com
Credit goes to github.com

Skip to content

switch from nose to pytest + GitHub Actions #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Jul 2, 2020
Merged

switch from nose to pytest + GitHub Actions #783

merged 41 commits into from
Jul 2, 2020

Conversation

@klauern
Copy link
Contributor

@klauern klauern commented Jun 9, 2020 •
edited
Loading

Description

Switching from using nose to Pytest, with the pytest-cov fixture to aid in code coverage as well.

Fixes #776

Also switches from Travis-CI to GitHub Actions.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

klauern added 30 commits May 30, 2020 12:23
@klauern
👷 add GitHub Actions
5e3c39a
@klauern
fix event that GHA triggers on
f0bf2d7
@klauern
add nose to dependencies installation
80ff6dc
@klauern
cache dependencies to speed up builds
3059401
@klauern
add more test deps
784cb7e
@klauern
remove unittest pip (built-in)
ebb9e45
@klauern
only run on pushes to master and PR's
f6fb177
@klauern
fix: remove forked differences
e8066d9 
We have additional changes in our forked branch of `develop`, need to
take those out
@klauern
add coverage callout
f4e5414
@klauern
use built-in coveralls github Action
c6e408c
@klauern
use codecov GHA
66c8b96
@klauern
remove optional fields, don't fail build on error in coverage
3388d88
@klauern
fix: specify coverage file
b56db05
@klauern
remove coveralls call
d378a49
@klauern
add additional run on 'master' branch
52b32c3
@klauern
rename test files to follow pytest convention
1c6ec8a
@klauern
Merge branch 'develop' of https://github.com/nccgroup/ScoutSuite into…
67f6c9b 
… feature/pytest
@klauern
testing: add development dependencies
8fc8826
@klauern
switch to unittest.mock
731f922
@klauern
switch from nose attr to pytest markers
04e7da9
@klauern
remove unused import
d2b5e1a
@klauern
import unittest; set all to be TestCases
76339d9
@klauern
remove unreachable return
58528bd
@klauern
tests: update Travis config for Pytest
0068d71
@klauern
fix coverage flag in travis
1286321
@klauern
version pinning pytest
1b58db5
@klauern
call pytest as a module
a6e69ac
@klauern
add coloredlogs dev dependency
f64b159
@klauern
fix: remove unused/unintegrated tests
71f2330
@klauern
fix requirements loading from dev-requirements
9504c64
@x4v13r64
Copy link
Collaborator

x4v13r64 commented Jun 9, 2020

Don't worry too much about the travis issues since we'll switch to Actions. You could actually make this PR against the #761 branch?

@klauern klauern changed the title WIP: switch from nose to pytest switch from nose to pytest Jun 9, 2020
@klauern klauern marked this pull request as ready for review June 9, 2020 17:40
@klauern klauern mentioned this pull request Jun 9, 2020
Closed
10 tasks
@klauern klauern changed the title switch from nose to pytest switch from nose to pytest / switch to GitHub Actions Jun 9, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #783 into develop will decrease coverage by 56.12%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #783       +/-   ##
============================================
- Coverage    66.53%   10.40%   -56.13%     
============================================
  Files           22      309      +287     
  Lines         1536     9859     +8323     
============================================
+ Hits          1022     1026        +4     
- Misses         514     8833     +8319
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/s3.py 0.00% <0.00%> (ø)
ScoutSuite/providers/aws/resources/s3/base.py 0.00% <0.00%> (ø)
ScoutSuite/utils.py 82.35% <75.00%> (-3.37%) ⬇️
ScoutSuite/core/console.py 65.07% <0.00%> (-0.80%) ⬇️
ScoutSuite/providers/aliyun/facade/ram.py 0.00% <0.00%> (ø)
...uite/providers/azure/resources/network/watchers.py 0.00% <0.00%> (ø)
...Suite/providers/oci/resources/identity/api_keys.py 0.00% <0.00%> (ø)
...ite/providers/aws/resources/rds/parametergroups.py 0.00% <0.00%> (ø)
...iders/azure/resources/virtualmachines/instances.py 0.00% <0.00%> (ø)
ScoutSuite/providers/aws/resources/vpc/base.py 0.00% <0.00%> (ø)
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac628c...71b0980. Read the comment docs.

@klauern
Copy link
Contributor Author

klauern commented Jun 9, 2020

I can't get the travis-ci check to do anything.

@x4v13r64
Copy link
Collaborator

I can't get the travis-ci check to do anything.

Looks like I also have to remove the integration on our end, I'll do it when merging this PR.

@klauern klauern changed the title switch from nose to pytest / switch to GitHub Actions switch from nose to pytest + GitHub Actions Jun 10, 2020
@x4v13r64 x4v13r64 added this to the 5.10 milestone Jun 11, 2020
@x4v13r64 x4v13r64 mentioned this pull request Jun 13, 2020
Open
@x4v13r64 x4v13r64 mentioned this pull request Jun 23, 2020
Merged
10 tasks
alessandrogonzalez
alessandrogonzalez reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@alessandrogonzalez alessandrogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Coverage has been reduced as now it looks like all the files in the project are taken into account. We'll have better visibility of the overall coverage.

@x4v13r64 x4v13r64 changed the base branch from develop to release/5.10 July 2, 2020 10:04
@x4v13r64 x4v13r64 merged commit fde9d71 into release/5.10 Jul 2, 2020
@x4v13r64 x4v13r64 deleted the feature/pytest branch July 2, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alessandrogonzalez alessandrogonzalez alessandrogonzalez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.10

Development

Successfully merging this pull request may close these issues.

5 participants

@klauern @x4v13r64 @codecov-commenter @alessandrogonzalez