speed up crps for ens with sort algorithm #928
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tennlee
reviewed
Oct 30, 2025
| ens_count = fcst.count(ensemble_member_dim) # Get M (number of non-NaN members for each point) | ||
| M_total = fcst.sizes[ensemble_member_dim] # Get M_total (total dimension size) | ||
|
|
||
| if M_total > 0: |
There was a problem hiding this comment.
This needs some more comments to explain why this is valid/equivalent to the unsorted method. This looks like a lot more than just sorting, also introducing co-efficients which for some reason and some kind of basic explanation of what's happening should be added to orient the reader.
There was a problem hiding this comment.
I think it would be useful to have a reference to the computational method in the comment below. Depending on the quality of the reference, that might be enough to satisfy me that the method is justified (not that I doubt your work Nick). Otherwise I'm in the position of having to prove the equivalence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up of >150x on sample data that is an array of 100x100x5 with 500 members.