Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: simplify adding new node versions add node 24 #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Aug 21, 2025
Merged

refactor: simplify adding new node versions add node 24 #5899

mergify merged 2 commits into from
Aug 21, 2025

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Aug 12, 2025 •
edited
Loading

  • CI is broken right now due to hello world action upgrade

@ChristopherHX ChristopherHX linked an issue Aug 12, 2025 that may be closed by this pull request
Allow using node24 #5883
Closed
ChristopherHX
ChristopherHX commented Aug 12, 2025
View reviewed changes
pkg/model/action.go

func (a ActionRunsUsing) IsNode() bool {
switch a {
case ActionRunsUsingNode12, ActionRunsUsingNode16, ActionRunsUsingNode20, ActionRunsUsingNode24:
Copy link
Contributor Author

@ChristopherHX ChristopherHX Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use string.HasPrefix(a, "node") as alternative

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.77s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.04s
✅ REPOSITORY secretlint yes no 1.28s
✅ REPOSITORY trivy-sbom yes no 0.4s
✅ REPOSITORY trufflehog yes no 3.75s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.79%. Comparing base (bd4bc99) to head (859524e).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/action.go 86.36% 3 Missing ⚠️
pkg/model/action.go 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5899      +/-   ##
==========================================
+ Coverage   74.65%   74.79%   +0.13%     
==========================================
  Files          73       73              
  Lines       11139    11200      +61     
==========================================
+ Hits         8316     8377      +61     
- Misses       2186     2187       +1     
+ Partials      637      636       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Aug 14, 2025

Gitea/act:https://gitea.com/gitea/act/pulls/140 PR via GitHub Copilot applied

@mergify mergify bot merged commit c8a205e into master Aug 21, 2025
12 checks passed
@mergify mergify bot deleted the 5883-allow-using-node24 branch August 21, 2025 23:07
@horothesun horothesun mentioned this pull request Aug 26, 2025
Merged
1 task
@millsks millsks mentioned this pull request Aug 31, 2025
Closed
@reneleonhardt
Copy link

reneleonhardt commented Sep 1, 2025

Broken CI means that the image will be rebuilt later for node24, this PR is not "active" yet? 🙂

$ dive catthehacker/ubuntu:act-latest  # built 3 days ago

├── opt                
│   ├── acttoolcache   
│   │   └── node       
│   │       ├─⊕ 16.20.2
│   │       ├─⊕ 18.20.8
│   │       └─⊕ 20.19.4

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Sep 1, 2025

No, your quoted folder is unused.

Broken CI means

Every other PR merge was prevented by branch/merge restrictions due to CI failures in nektos/act PRs not including this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panekj panekj panekj approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow using node24

4 participants

@ChristopherHX @reneleonhardt @panekj