fix: use non strict schema to allow some undefined behavior #2524
Conversation
* GitHub Actions doesn't use the newer strict schema in the service * Tolerate more hallucinations
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
|
@jsoref What do you think? This appends an informal error if schema fails. I thought about adding strict validation after weak validation as warning, but the planner code doesn't have the context where the logger can be substituted... :( Docu update here: nektos/act-docs#32 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2524 +/- ##
===========================================
+ Coverage 61.56% 74.42% +12.85%
===========================================
Files 53 72 +19
Lines 9002 11053 +2051
===========================================
+ Hits 5542 8226 +2684
+ Misses 3020 2191 -829
- Partials 440 636 +196 ☔ View full report in Codecov by Sentry. |
jsoref
left a comment
There was a problem hiding this comment.
jsoref@jsoref-mbp winget-dsc % act --version
act version 0.2.69
jsoref@jsoref-mbp winget-dsc % act -l 2>&1|tail -3
Line: 37 Column 3: Failed to match on-sequence-strict: Line: 37 Column 3: Expected a sequence got mapping
Line: 37 Column 3: Failed to match on-mapping-strict: Line: 43 Column 5: Failed to match null: Line: 43 Column 5: Expected a scalar got mapping
Line: 43 Column 5: Failed to match pull-request-target-mapping: Line: 45 Column 5: Unknown Property tags-ignorejsoref@jsoref-mbp winget-dsc % ~/code/nektos/act/dist/local/act --version
act version b253c5d
jsoref@jsoref-mbp winget-dsc % ~/code/nektos/act/dist/local/act -l
INFO[0000] Using docker host 'unix:///var/run/docker.sock', and daemon socket 'unix:///var/run/docker.sock'
WARN ⚠ You are using Apple M-series chip and you have not specified container architecture, you might encounter issues while running act. If so, try running it with '--container-architecture linux/amd64'. ⚠
Stage Job ID Job name Workflow name Workflow file Events
0 spelling Check Spelling Spell Checking spellCheck.yaml push,pull_request_target
1 comment-push Report (Push) Spell Checking spellCheck.yaml push,pull_request_target
1 comment-pr Report (PR) Spell Checking spellCheck.yaml pull_request_target,pushI was expecting to see an error message...
In theory, I like these changes, but..., for reasons I don't understand, I'm not seeing them.
The error level has been lowered. Custom properties in on are no failure anymore. |
Co-authored-by: Josh Soref <[email protected]>
Provide Guidance