Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@panekj
Copy link
Contributor

@panekj panekj commented Feb 22, 2025

Remove Gitter (which is now hosted on Matrix) since it's been abandoned for way too long

@panekj panekj requested a review from a team as a code owner February 22, 2025 14:23
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.01s
✅ MARKDOWN markdownlint 2 0 0.39s
✅ REPOSITORY gitleaks yes no 2.7s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.79s
✅ REPOSITORY secretlint yes no 1.22s
✅ REPOSITORY trivy-sbom yes no 0.38s
✅ REPOSITORY trufflehog yes no 3.75s
✅ YAML prettier 1 0 0.23s
✅ YAML v8r 1 0 1.12s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

ChristopherHX
ChristopherHX previously approved these changes Feb 22, 2025
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...this is one gitter leftover, there is one in issue templates as well

@panekj panekj marked this pull request as draft February 22, 2025 14:27
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (5a80a04) to head (3887cd2).
Report is 203 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2678       +/-   ##
===========================================
+ Coverage   61.56%   74.64%   +13.08%     
===========================================
  Files          53       73       +20     
  Lines        9002    11139     +2137     
===========================================
+ Hits         5542     8315     +2773     
+ Misses       3020     2189      -831     
- Partials      440      635      +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panekj panekj force-pushed the panekj/docs/remove-gitter branch from a8f8d62 to 3cd53c3 Compare May 22, 2025 19:44
@panekj panekj force-pushed the panekj/docs/remove-gitter branch from 3cd53c3 to f50f98b Compare May 22, 2025 19:45
@panekj panekj marked this pull request as ready for review May 22, 2025 19:47
@panekj
Copy link
Contributor Author

panekj commented May 22, 2025

Replaced gitter with links to github discussions where applicable

@ChristopherHX
Copy link
Contributor

I would like to merge this, however I am only able to do this with working CI...

Somewhat offtopic, but important

In TestHostEnvironment I would disable the following test

  	// Disabled for now because this test is somewhat invalid
  	// shell sh is not necessarily bash if the job has no override
  	// {workdir, "defaults-run", "push", "", platforms, secrets},

I assume sh is now no longer bash for GitHub Hosted Runners. "A test that asserts bash with a default shell sh", this condition can be true, but is not required by spec.

If you would approve such a PR, I will create one. This is an implicit part of enhancing workflow command logging...

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the needs-work Extra attention is needed label May 22, 2025
@panekj
Copy link
Contributor Author

panekj commented May 22, 2025

If you would approve such a PR, I will create one.

Sure, if there's anything that you think would benefit the project or need help with, I'm in

Remove Gitter (which is now hosted on Matrix) since it's been abandoned for way too long
@panekj panekj force-pushed the panekj/docs/remove-gitter branch from f50f98b to 3887cd2 Compare May 22, 2025 21:01
@mergify mergify bot removed the needs-work Extra attention is needed label May 22, 2025
@mergify mergify bot merged commit f0da96d into master May 22, 2025
12 checks passed
@mergify mergify bot deleted the panekj/docs/remove-gitter branch May 22, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants